Add QC field in .yml list for `sct_detect_pmj` #3448

sandrinebedard · 2021-07-12T15:19:06Z

Checklist

I've given this PR a concise, self-descriptive, and meaningful title
I've linked relevant issues in the PR body
I've applied the relevant labels to this PR
I've applied a release milestone (major, minor, patch) in line with Semantic Versioning guidelines
I've assigned a reviewer

I've consulted SCT's internal developer documentation to ensure my contribution is in line with any relevant design decisions
I've added relevant tests for my contribution
I've updated the relevant documentation for my changes, including argparse descriptions, docstrings, and ReadTheDocs tutorial pages

This PR addresses #3445.
This PR includes:

A field FILES_PMJ for the YAML list generated in QC report for sct_detect_pmj
Modification of FILES_SEG for FILES_REG for sct_register_multimodal, sct_register_to_template and sct_warp_template.

Resolves #3445

joshuacwnewton

This makes sense to me in the short term!

(Though of course, in the long-term, there is what you mentioned in in #3445 (comment).)

sandrinebedard added 2 commits July 12, 2021 10:53

add FILES_PMJ for sct_detect_pmj

3c89a3d

add FILES_REG for registration functions

6943aa8

sandrinebedard added the sct_qc context: label Jul 12, 2021

sandrinebedard added this to the 5.4 milestone Jul 12, 2021

sandrinebedard requested review from jcohenadad and joshuacwnewton July 12, 2021 15:19

joshuacwnewton approved these changes Jul 12, 2021

View reviewed changes

jcohenadad approved these changes Jul 12, 2021

View reviewed changes

joshuacwnewton merged commit 5a6586b into master Jul 13, 2021

joshuacwnewton deleted the sb/3445-add-fields-qc-yml branch July 13, 2021 14:43

joshuacwnewton added the enhancement category: improves performance/results of an existing feature label Sep 24, 2021