Clean up install/, issues/, and flirtsch/ folders in repo
#3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These scripts were developed 6 years ago to help a user on the SourceForge help forum. They are out of date, and unlikely to be of use to anyone presently.
Most of the scripts in this folder are outdated/unused/broken. This used to be a module needed for SCT installation/updating, but is no longer a part of the core SCT package, and is mostly a relic of a previous era of SCT development. Therefore, it should be relegated to the 'dev/' folder to avoid confusing new contributors. NB: The 'dev/' folder itself is in need of cleanup, but that would be a larger undertaking.
|
Regarding 24bcc1d, if we wanted to be really thorough about these |
joshuacwnewton
commented
Jul 19, 2021
9 tasks
8 tasks
As per @jcohenadad's suggestion in #3559 (comment).
joshuacwnewton
changed the title
install/ and issues/ folders in repoinstall/, issues/, and flirtsch/ folders in repo
jcohenadad
approved these changes
Nov 22, 2021
joshuacwnewton
added a commit
that referenced
this pull request
Jan 18, 2022
* `issues/`: Delete outdated user scripts These scripts were developed 6 years ago to help a user on the SourceForge help forum. They are out of date, and unlikely to be of use to anyone presently. * 'install/': Move inside `dev/` folder Most of the scripts in this folder are outdated/unused/broken. This used to be a module needed for SCT installation/updating, but is no longer a part of the core SCT package, and is mostly a relic of a previous era of SCT development. Therefore, it should be relegated to the 'dev/' folder to avoid confusing new contributors. NB: The 'dev/' folder itself is in need of cleanup, but that would be a larger undertaking. * Delete `flirtsch/` folder As per @jcohenadad's suggestion, as the link in Tanguy's paper can't be changed, and the benefits outweigh the cons.
joshuacwnewton
added
git/github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
GitHub
PR contents
Description
I few months ago, I was inspired by this ARCHITECTURE.md article to write a "Project Overview" page for the SCT Wiki. My goal was to make SCT's project architecture easier to understand, so that new contributors wouldn't feel lost or intimidated, and could find what they need in the codebase. Writing that page made me realize that there are some small ways we can clean up the repo so that it will be slightly easier to navigate for new contributors:
install/(worth preserving for now) andissues//flirtsch/(no longer useful, so delete). )Linked issues
Closes #3559.