New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measure CSA based on distance from pontomedullary junction (PMJ) #3478
Conversation
Co-authored-by: Julien Cohen-Adad <jcohen@polymtl.ca>
I've cleaned up and added some comments to the code, I think it would be ready to merge! We also discussed that we need to update the documentation with this new feature, do we want to address that soon? (I can also open an issue for this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not giving this feedback sooner... I probably should have looked at this much earlier, before the QC PR. 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing contribution @sandrinebedard !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few nitpicky suggestions, but for the most part, this LGTM!
I'd say feel free to merge after this! 🙂
Co-authored-by: Joshua Newton <joshuacwnewton@gmail.com>
Co-authored-by: Joshua Newton <joshuacwnewton@gmail.com>
Co-authored-by: Joshua Newton <joshuacwnewton@gmail.com>
Checklist
GitHub
PR contents
Description
This PR addressed #3063. The goal is to measure CSA based on a distance from pontomedullary junction (PMJ) To take into account the curvature of the spinal cord, we use linear interpolation between PMJ and centerline. We can after measure the distance along the centerline.
This PR adds the API
csa_pmj.py
and intergrates the method insct_process_segmentation
andaggregate_slicewise.py
.It also adds QC report for this method.
Note: we will need to update the documentation
Linked issues
Resolves #3063 and closes #3431