Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure CSA based on distance from pontomedullary junction (PMJ) #3478

Merged
merged 68 commits into from Aug 3, 2021

Conversation

sandrinebedard
Copy link
Member

@sandrinebedard sandrinebedard commented Jul 19, 2021

Checklist

GitHub

PR contents

Description

This PR addressed #3063. The goal is to measure CSA based on a distance from pontomedullary junction (PMJ) To take into account the curvature of the spinal cord, we use linear interpolation between PMJ and centerline. We can after measure the distance along the centerline.

This PR adds the API csa_pmj.py and intergrates the method in sct_process_segmentation and aggregate_slicewise.py.
It also adds QC report for this method.

Note: we will need to update the documentation

Linked issues

Resolves #3063 and closes #3431

sandrinebedard and others added 30 commits June 17, 2021 17:53
Co-authored-by: Julien Cohen-Adad <jcohen@polymtl.ca>
Co-authored-by: Julien Cohen-Adad <jcohen@polymtl.ca>
@sandrinebedard sandrinebedard added this to the 5.4 milestone Jul 29, 2021
@sandrinebedard
Copy link
Member Author

I've cleaned up and added some comments to the code, I think it would be ready to merge! We also discussed that we need to update the documentation with this new feature, do we want to address that soon? (I can also open an issue for this)

Copy link
Member

@joshuacwnewton joshuacwnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not giving this feedback sooner... I probably should have looked at this much earlier, before the QC PR. 😅

Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing contribution @sandrinebedard !!

Copy link
Member

@joshuacwnewton joshuacwnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few nitpicky suggestions, but for the most part, this LGTM!

I'd say feel free to merge after this! 🙂

spinalcordtoolbox/scripts/sct_process_segmentation.py Outdated Show resolved Hide resolved
spinalcordtoolbox/scripts/sct_process_segmentation.py Outdated Show resolved Hide resolved
testing/cli/test_cli_sct_process_segmentation.py Outdated Show resolved Hide resolved
sandrinebedard and others added 3 commits August 2, 2021 17:15
Co-authored-by: Joshua Newton <joshuacwnewton@gmail.com>
Co-authored-by: Joshua Newton <joshuacwnewton@gmail.com>
Co-authored-by: Joshua Newton <joshuacwnewton@gmail.com>
@sandrinebedard sandrinebedard merged commit f52843d into master Aug 3, 2021
@sandrinebedard sandrinebedard deleted the jca/sb/3063-csa-measure-from-pmj branch August 3, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature category: new functionality sct_process_segmentation context:
Projects
None yet
3 participants