Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the output files of sct_smooth_spinalcord (smooth.nii.gz, straight_ref.nii.gz) #3506

Merged
merged 6 commits into from Aug 25, 2021

Conversation

joshuacwnewton
Copy link
Member

@joshuacwnewton joshuacwnewton commented Aug 23, 2021

Checklist

GitHub

PR contents

Description

Two small fixes to address the observations from the SCT Course tutorial PR:

  1. Output the smoothed spinal cord as a compressed NIfTI file, rather than an uncompressed file.
  2. Output the straight_ref.nii.gz file (which is needed for reusing cached results, but wasn't copied over from the temp directory).
An aside...

I'm a little suspicious about this caching behavior... the cache logic is repeated across multiple scripts (smooth_spinalcord, label_vertebrae, register_to_template), but there are subtle changes each time... I wonder if it could be handled by sct_straighten_spinalcord itself instead. That being said, I'd rather keep this change small for now.

Linked issues

Fixes #3503.

@joshuacwnewton joshuacwnewton added bug category: fixes an error in the code sct_smooth_spinalcord context: labels Aug 23, 2021
@joshuacwnewton joshuacwnewton added this to the 5.4 milestone Aug 23, 2021
* Merge the two redundant tests into one
* Make the cache file behavior a little more explicit
@joshuacwnewton joshuacwnewton force-pushed the jn/3503-smooth-spinalcord-output-files branch from 82b3df9 to bc71907 Compare August 24, 2021 14:14
@joshuacwnewton joshuacwnewton self-assigned this Aug 24, 2021
@joshuacwnewton joshuacwnewton merged commit c5f1944 into master Aug 25, 2021
@joshuacwnewton joshuacwnewton deleted the jn/3503-smooth-spinalcord-output-files branch August 25, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug category: fixes an error in the code sct_smooth_spinalcord context:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output of sct_smooth_spinalcord includes 1 uncompressed .nii image, and 1 missing image
2 participants