New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -owarpinv
to sct_register_multimodal
#3507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it out with -owarpinv
and it works well! However, when I don't specify the flag, the inverse warping field is not created, but it should be... this may explain the batch pocessing test failling
Oops. There was a typo on my part. Sorry about that. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well now! 🎉
One suggestion, we could also remove the lines renaming the warping fileds in batch_processing.sh
and use -owarp
and -owarpinv
as we want to do in the tutorials 😊
Ahhh, that's a very good point! Thank you for the reminder. It's easy to forget. 😅 As an aside, it might be worth investigating how much overlap there is between |
Checklist
GitHub
PR contents
Description
This PR add the ability to specify the filename of the output inverse warping field. This is relevant for the SCT Course, since we often would rename the files using
mv
(because the auto-generated filenames were long and awkward).For this PR, I've tried to mimic the existing programming conventions in
sct_register_multimodal
(basically just matching-owarp
without making any further improvements), just to keep the changes easier to understand/review.Linked issues
Fixes #1530.