Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove misleading FSLeyes installation instructions #3577

Conversation

joshuacwnewton
Copy link
Member

@joshuacwnewton joshuacwnewton commented Nov 12, 2021

Checklist

GitHub

PR contents

Description

While going over our installation pages, I noticed the installation/fsleyes.rst page that I had never seen before. But:

  • FSLeyes should not be installed in the SCT venv (see this issue), so these instructions could mislead users into breaking their SCT installation.
  • I believe that the "FSLeyes Integration" page is sufficient, and that we do not need a second page.

Linked issues

Fixes #3223.

* FSLeyes should not be installed in the SCT venv
* The "FSLeyes Integration" page is sufficient; we do not need a second page.
@jcohenadad jcohenadad added the documentation category: readthedocs, sourceforge, or SCT courses label Nov 12, 2021
@jcohenadad jcohenadad added this to the 5.5 milestone Nov 12, 2021
@jcohenadad
Copy link
Member

@joshuacwnewton i've added label/milestone-- feel free to disregard

@joshuacwnewton
Copy link
Member Author

@joshuacwnewton i've added label/milestone-- feel free to disregard

Perfect! I was rushing a bit, so thank you. 🙂

@joshuacwnewton joshuacwnewton merged commit b7e7479 into master Nov 12, 2021
@joshuacwnewton joshuacwnewton deleted the jn/3223-remove-misleading-fsleyes-installation-instructions branch November 12, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation category: readthedocs, sourceforge, or SCT courses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add explanation of FSLeyes installation/integration for Mac/Linux users
2 participants