Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_sct: Skip pip==21.2 to avoid suboptimal dependency resolver #3594

Merged
merged 1 commit into from Nov 18, 2021

Conversation

joshuacwnewton
Copy link
Member

Checklist

GitHub

PR contents

Description

pip==21.2.*'s dependency resolver algorithm caused much longer install times across the Python ecosystem. This change makes sure we're not on that version before we install SCT's requirements.

Linked issues

Fixes #3593.

@joshuacwnewton joshuacwnewton added the installation category: install_sct or pip/setup.py label Nov 18, 2021
@joshuacwnewton joshuacwnewton added this to the 5.5 milestone Nov 18, 2021
Comment on lines +634 to +635
# Skip pip==21.2 to avoid dependency resolver issue (https://github.com/spinalcordtoolbox/spinalcordtoolbox/issues/3593)
python -m pip install -U "pip!=21.2.*"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I initially tried to specify the version of pip using conda (in the conda create step, for example), but no matter what I did, conda kept thinking that pip!=21.2.* required python=3.9. And, I tried a lot of different syntax combinations to no avail. 😓

So, I'm just using pip to update itself here instead.

@joshuacwnewton joshuacwnewton merged commit f13fab1 into master Nov 18, 2021
@joshuacwnewton joshuacwnewton deleted the jn/3593-avoid-pip-21.2 branch November 18, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation category: install_sct or pip/setup.py
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip==21.2 is taking many hours to resolve dependencies
2 participants