Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove channel=None bugfix that was superseded by upstream skimage=0.19.1 patch #3652

Merged
merged 2 commits into from Jan 14, 2022
Merged

Remove channel=None bugfix that was superseded by upstream skimage=0.19.1 patch #3652

merged 2 commits into from Jan 14, 2022

Conversation

sandrinebedard
Copy link
Member

@sandrinebedard sandrinebedard commented Jan 14, 2022 •
edited

Checklist

GitHub

PR contents

Description

THis PR addresses #3651. A fix was added for the version 0.19.0 of scikit-image (#3615), adding the argument channel_axis=None. Since the package scikit image has been upgrated to 0.19.1, it is no longer necessary, we can remove it.

Linked issues

Resolves #3651

@sandrinebedard sandrinebedard added this to the 5.5 milestone Jan 14, 2022
RignonNoel
RignonNoel approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@RignonNoel RignonNoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on @joshuacwnewton comments on the issue and on the note everything seems good here.

@joshuacwnewton joshuacwnewton changed the title Sb/3651 remove unexpected arg Remove channel=None bugfix that was superseded by upstream skimage=0.19.1 patch Jan 14, 2022
@joshuacwnewton joshuacwnewton merged commit 6f29a02 into master Jan 14, 2022
@joshuacwnewton joshuacwnewton deleted the sb/3651-remove-unexpected-arg branch January 14, 2022 15:59
@joshuacwnewton
Copy link
Member

Thank you so much for taking the initiative on this, @sandrinebedard! 🎉

RignonNoel pushed a commit to RignonNoel/spinalcordtoolbox that referenced this pull request Jan 21, 2022
@sandrinebedard @RignonNoel
Remove channel=None bugfix that was superseded by upstream `skimage…
e3d842d 
…=0.19.1` patch (spinalcordtoolbox#3652)
@joshuacwnewton joshuacwnewton added the refactoring category: improves code structure without affecting user-facing functionality label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RignonNoel RignonNoel RignonNoel approved these changes

@joshuacwnewton joshuacwnewton joshuacwnewton approved these changes

Assignees
No one assigned
Labels
refactoring category: improves code structure without affecting user-facing functionality SCT API: process_seg.py context:
Projects
None yet
Milestone
5.5
Development

Successfully merging this pull request may close these issues.

pyramid_expand() got an unexpected keyword argument 'channel_axis when using sct_process_segmentation
3 participants
@sandrinebedard @joshuacwnewton @RignonNoel