Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CentOS 8 with CentOS Stream 8 to address December 2021 EOL #3676

Merged
merged 3 commits into from Feb 3, 2022
Merged

Replace CentOS 8 with CentOS Stream 8 to address December 2021 EOL #3676

merged 3 commits into from Feb 3, 2022

Conversation

joshuacwnewton
Copy link
Member

@joshuacwnewton joshuacwnewton commented Jan 31, 2022 •
edited

Checklist

GitHub

PR contents

Description

This is a fix for the CentOS 8 EOL, which went into effect today. Quay.io is an official RHEL channel.

Also, context for this fix can be found in
https://blog.centos.org/2020/12/future-is-centos-stream/:

When CentOS Linux 8 (the rebuild of RHEL8) ends, your best
option will be to migrate to CentOS Stream 8, which is a
small delta from CentOS Linux 8, and has regular updates like
traditional CentOS Linux releases.

Linked issues

Fixes #3675.

@joshuacwnewton
tests.yml: Try CentOS Stream 8 over CentOS 8
d6d3db3 
Quay.io is an official RHEL channel.

Also, context for this fix can be found in
https://blog.centos.org/2020/12/future-is-centos-stream/:

> When CentOS Linux 8 (the rebuild of RHEL8) ends, your best
> option will be to migrate to CentOS Stream 8, which is a
> small delta from CentOS Linux 8, and has regular updates like
> traditional CentOS Linux releases.
@joshuacwnewton joshuacwnewton changed the title Try CentOS Stream 8 over CentOS 8 Try CentOS Stream 8 in CI to fix CentOS 8 EOL Jan 31, 2022
@codecov
Copy link

codecov bot commented Jan 31, 2022 •
edited

Codecov Report

Merging #3676 (dda7d33) into master (fc34ee9) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
api-tests 24.45% <ø> (ø)
cli-tests 56.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@joshuacwnewton joshuacwnewton added the CI category: TravisCI, GitHub Actions, etc. label Jan 31, 2022
@joshuacwnewton joshuacwnewton self-assigned this Jan 31, 2022
@joshuacwnewton joshuacwnewton changed the title Try CentOS Stream 8 in CI to fix CentOS 8 EOL Replace CentOS 8 with CentOS Stream 8 to address December 2021 EOL Jan 31, 2022
@joshuacwnewton joshuacwnewton added this to the 5.6 milestone Jan 31, 2022
@joshuacwnewton joshuacwnewton marked this pull request as ready for review January 31, 2022 22:02
@joshuacwnewton joshuacwnewton mentioned this pull request Feb 1, 2022
Merged
8 tasks
mguaypaq
mguaypaq approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@joshuacwnewton @mguaypaq
CentOS 8 -> CentOS Stream 8
dda7d33 
Co-authored-by: Mathieu Guay-Paquet <mathieu.guaypaquet@gmail.com>
@joshuacwnewton

This comment was marked as outdated.

Sign in to view
@joshuacwnewton joshuacwnewton merged commit 7e7d8a4 into master Feb 3, 2022
@joshuacwnewton joshuacwnewton deleted the jn/3675-update-centos-ci-runners branch February 3, 2022 14:45
joshuacwnewton added a commit to spinalcordtoolbox/build_ANTs that referenced this pull request May 6, 2022
@joshuacwnewton
ccpp.yml: Replace centos:8 with centos:stream8
c6fcbd6 
`centos:8` reached EOL in December 2021. A similar change was
performed in spinalcordtoolbox/spinalcordtoolbox#3676.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguaypaq mguaypaq mguaypaq approved these changes

@RignonNoel RignonNoel Awaiting requested review from RignonNoel

Assignees

@joshuacwnewton joshuacwnewton

Labels
CI category: TravisCI, GitHub Actions, etc.
Projects
None yet
Milestone
5.6
Development

Successfully merging this pull request may close these issues.

CentOS 8 runner - Error: Failed to download metadata for repo 'appstream'
2 participants
@joshuacwnewton @mguaypaq