Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt: Update -f link for PyTorch CPU HTML page #3679

Merged
merged 3 commits into from Feb 10, 2022

Conversation

joshuacwnewton
Copy link
Member

@joshuacwnewton joshuacwnewton commented Feb 2, 2022

Checklist

GitHub

PR contents

Description

The link we're using currently throws a deprecation warning:

DEPRECATION: The HTML index page being used (https://download.pytorch.org/whl/cpu/torch_stable.html) is not a proper HTML 5 document. This is in violation of PEP 503 which requires these pages to be well-formed HTML 5 documents. Please reach out to the owners of this index page, and ask them to update this index page to a valid HTML 5 document. pip 22.2 will enforce this behaviour change. Discussion can be found at pypa/pip#10825

I've implemented the suggestion from: pytorch/pytorch#72180 (comment)

Linked issues

N/A

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #3679 (d8a2224) into master (7e7d8a4) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
api-tests 24.20% <ø> (-0.26%) ⬇️
cli-tests 56.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@joshuacwnewton joshuacwnewton added the installation category: install_sct or pip/setup.py label Feb 2, 2022
@joshuacwnewton joshuacwnewton self-assigned this Feb 2, 2022
@joshuacwnewton joshuacwnewton added this to the 5.6 milestone Feb 2, 2022
@joshuacwnewton joshuacwnewton marked this pull request as ready for review February 2, 2022 17:55
Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing, reporting to upstream, and finding the correct paths to use! LGTM

@joshuacwnewton joshuacwnewton merged commit 7e92850 into master Feb 10, 2022
@joshuacwnewton joshuacwnewton deleted the jn/update-pytorch-html-index-page branch February 10, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation category: install_sct or pip/setup.py
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants