Account for non-UNIX platforms in sys.platform
checks
#3722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we'd get a "referenced before assignment" error on
Windows.
Checklist
GitHub
PR contents
Description
This PR fills in the gaps for platforms outside of
darwin
andlinux
.I think this check probably could use a more thorough rewrite, though? I'm skeptical of its purpose.
Linked issues
Fixes #3709.