Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation build instructions #3734

Merged
merged 2 commits into from Mar 14, 2022
Merged

Update documentation build instructions #3734

merged 2 commits into from Mar 14, 2022

Conversation

mguaypaq
Copy link
Member

The sphinx/ subdirectory of documentation/ no longer exists.

The sphinx/ subdirectory of documentation/ no longer exists.
@mguaypaq mguaypaq added the documentation category: readthedocs, sourceforge, or SCT courses label Mar 14, 2022
@mguaypaq mguaypaq added this to the 5.6 milestone Mar 14, 2022
@mguaypaq mguaypaq self-assigned this Mar 14, 2022
Copy link
Member

@joshuacwnewton joshuacwnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Huh. I forgot that this README.rst even exists?

I've been writing and maintaining https://github.com/spinalcordtoolbox/spinalcordtoolbox/wiki/Documentation instead.

IIRC the person who added this page had suggested that it was more discoverable to have in-line documentation than to have it on the Wiki. But, I can't tell if that's just lead this page to being more difficult to maintain. 😆

Approving this change, but... It may be worth considering wiping out this README.rst and replacing it with a suggestion to view the Documentation section of the internal wiki instead, just so that we have a single source of truth for our dev documentation. 🤔

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #3734 (6cb10d2) into master (84c4aa3) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
api-tests 22.30% <ø> (-0.01%) ⬇️
cli-tests 58.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mguaypaq mguaypaq merged commit 2c48843 into master Mar 14, 2022
@mguaypaq mguaypaq deleted the mgp/docs_readme branch March 14, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation category: readthedocs, sourceforge, or SCT courses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants