Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install_sct.bat: Allow overwriting of existing spinalcordtoolbox installations #3747

Merged
merged 2 commits into from Apr 5, 2022
Merged

install_sct.bat: Allow overwriting of existing spinalcordtoolbox installations #3747

merged 2 commits into from Apr 5, 2022

Conversation

joshuacwnewton
Copy link
Member

Checklist

GitHub

PR contents

Description

This PR allows the Windows install script to proceed more gracefully if there is an existing spinalcordtoolbox directory.

Linked issues

Addresses #3740 (comment).

@joshuacwnewton joshuacwnewton added installation category: install_sct or pip/setup.py OS: Windows (native) labels Apr 4, 2022
@joshuacwnewton joshuacwnewton self-assigned this Apr 4, 2022
@joshuacwnewton joshuacwnewton marked this pull request as draft April 4, 2022 18:47
@codecov
Copy link

codecov bot commented Apr 4, 2022 •
edited

Codecov Report

Merging #3747 (417dc1d) into master (ca31bad) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
api-tests 22.27% <ø> (-0.01%) ⬇️
cli-tests 58.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@joshuacwnewton
install_sct.bat: Refactor :error into :error+:exit
b09ce7e
@joshuacwnewton
install_sct.bat: Add prompt for opting in to overwriting
417dc1d 
This fixes the issue when `install_sct.bat` is run multiple
times (and so there would be a `spinalcordtoolbox/` folder
already). See:

#3740 (comment)
@joshuacwnewton joshuacwnewton force-pushed the jn/3740-allow-overwriting-windows-install branch from 6476161 to 417dc1d Compare April 4, 2022 19:04
@joshuacwnewton joshuacwnewton marked this pull request as ready for review April 4, 2022 19:05
@joshuacwnewton joshuacwnewton mentioned this pull request Apr 4, 2022
Closed
@joshuacwnewton joshuacwnewton added this to the 5.6 milestone Apr 4, 2022
RignonNoel
RignonNoel approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@RignonNoel RignonNoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good and well documented 👍

@joshuacwnewton joshuacwnewton merged commit f3b28c0 into master Apr 5, 2022
@joshuacwnewton joshuacwnewton deleted the jn/3740-allow-overwriting-windows-install branch April 5, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RignonNoel RignonNoel RignonNoel approved these changes

@mguaypaq mguaypaq Awaiting requested review from mguaypaq

Assignees

@joshuacwnewton joshuacwnewton

Labels
installation category: install_sct or pip/setup.py OS: Windows (native)
Projects
None yet
Milestone
5.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshuacwnewton @RignonNoel