Repair automated commenting out of pre-4.0 sct settings

[kousu]

Checklist

GitHub

• I've given this PR a concise, self-descriptive, and meaningful title
• I've linked relevant issues in the PR body
• I've applied the relevant labels to this PR
• I've applied a release milestone (major, minor, patch) in line with Semantic Versioning guidelines
• I've assigned a reviewer

PR contents

• I've consulted SCT's internal developer documentation to ensure my contribution is in line with any relevant design decisions
• I've added relevant tests for my contribution
• I've updated the relevant documentation for my changes, including argparse descriptions, docstrings, and ReadTheDocs tutorial pages

Description

See #3804

This was inadvertently broken in #3591.

Linked issues

Fixes #3804

[kousu]

I fear this will be difficult to test, because I've never seen a pre-4.0 SCT-installed bashrc file.

But I'll ask https://forum.spinalcordmri.org/t/sct-5-6-installation-failed/884/ to provide one, so hopefully that'll give us a check.

[kousu]

regexes!!

[codecov]

Codecov Report

Merging #3805 (3f5e03e) into master (ca5e661) will not change coverage.
The diff coverage is n/a.

❗ Current head 3f5e03e differs from pull request most recent head c39132f. Consider uploading reports for the commit c39132f to get more accurate results

Flag	Coverage Δ
api-tests	22.63% <ø> (ø)
cli-tests	58.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[joshuacwnewton]

Pre-approving, as I think my proposed change is relatively simple and easy to verify?

[kousu]

Great, thanks for testing quickly! I think your proposed patch isn't idempotent. The previous sed line was idempotent: it would replace 0 or more '#'s at the start of a line with a single '#'. Anyway you don't need to match the trailing line to comment it out. But I'm on my way out to the lab lunch so I'll won't be able to actually double check myself for an hour or two. Just try running it a couple times on the same file and see what it does.

[joshuacwnewton]

@kousu Did something glitch here with your email response? It seems like this was intended to be sent some time ago...

(I notice you sent a similar comment in #3805 (comment), so I presume this has been resolved already, especially given that this fix was later tweaked in #3872.)

[kousu]

I was 😴 six hours ago. This isn't the first time GitHub has lagged email to/from me.

[kousu]

But that's literally from months ago. Has it been sitting in some redis queue all this time? 🔄