Update docstring for the aggregate_per_slice_or_level function
#3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These comments used to be necessary to silence a PyCharm code inspection. The warning was caused by a test function argument being named the same as a custom pytest fixture defined in the file (which can't be helped: that's how pytest fixtures work). But from a quick test on my laptop, it looks like PyCharm is now smart enough to recognize this pattern, and doesn't warn about it anymore.
Following #3823, aggregating from vertebral levels respects the restriction to a subset of slices, instead of superseding it.
mguaypaq
added
refactoring
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshuacwnewton
approved these changes
Jul 4, 2022
mguaypaq
changed the title
aggregate_per_slice_or_level function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two small followup changes after #3823:
# noinspection 801,PyShadowingNamescomments in various test files are no longer necessary (see Clean up obsoletenoinspectioncomments #3824).aggregate_per_slice_or_levelgot out of sync with the code.Linked issues
Fixes #3824.