New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new tutorial for contrast agnostic registration #3831
Conversation
The last tutorial in the "registration-to-template" section ("MTR Computation") doesn't actually use the template at all! Instead, it involves using `sct_register_multimodal` to coregister two *non-template* images together. Additionally, in the next commits, I will be adding a second tutorial that *also* involes coregistering two non-template images together. So, given that we will have a pair of similar tutorials, it makes sense to break them off into their own section.
...ction/tutorials/non-template-registration/contrast-agnostic-registration/before-starting.rst
Outdated
Show resolved
Hide resolved
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is written clearly, and follows the style of the other tutorials. After downloading t1.nii.gz
and t2.nii.gz
directly from the sct_tutorial_data
repo, I was able to run all the steps. I like the images you included at the bottom of each page of the tutorial.
I guess the commands for using the warping fields produced during this tutorial are more advanced and out of scope.
(I did run into a few errors at first, but that's just because I hadn't re-run sct_install
recently, so I was missing some sct_download_data
datasets and some pip install -r requirements.txt
dependencies.)
...n/tutorials/non-template-registration/contrast-agnostic-registration/coregistering-t1-t2.rst
Outdated
Show resolved
Hide resolved
...n/tutorials/non-template-registration/contrast-agnostic-registration/coregistering-t1-t2.rst
Outdated
Show resolved
Hide resolved
...tion/tutorials/non-template-registration/contrast-agnostic-registration/preprocessing-t1.rst
Outdated
Show resolved
Hide resolved
...ction/tutorials/non-template-registration/contrast-agnostic-registration/before-starting.rst
Outdated
Show resolved
Hide resolved
documentation/source/user_section/tutorials/non-template-registration.rst
Outdated
Show resolved
Hide resolved
...n/source/user_section/tutorials/non-template-registration/contrast-agnostic-registration.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responding to parellel feedback from spinalcordtoolbox/spinalcordtoolbox#3831 (comment).
Ah! Good catch! This is because the argparse help description was not updated in #3807. Fixing this now. 🤦 |
documentation/source/user_section/tutorials/non-template-registration.rst
Outdated
Show resolved
Hide resolved
...n/source/user_section/tutorials/non-template-registration/contrast-agnostic-registration.rst
Outdated
Show resolved
Hide resolved
...n/tutorials/non-template-registration/contrast-agnostic-registration/coregistering-t1-t2.rst
Outdated
Show resolved
Hide resolved
...n/tutorials/non-template-registration/contrast-agnostic-registration/coregistering-t1-t2.rst
Outdated
Show resolved
Hide resolved
…tion explanation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions added. This is an excellent tutorial addition, thank you so much @joshuacwnewton !!
Checklist
GitHub
PR contents
Description
This PR adds a new tutorial to the registration section of the SCT tutorials, corresponding to @EvanBeal's new contrast agnostic registration method.
I've also made identical changes to the SCT Course PDF. (p76-p80)
Linked issues
N/A, but related to #3760.