Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install_sct.bat as a release asset during create-release.yml workflow #3850

Merged
merged 2 commits into from Jul 26, 2022

Conversation

joshuacwnewton
Copy link
Member

Checklist

GitHub

PR contents

Description

This PR updates the create release workflow so that it will modify install_sct.bat to make it release-ready, then attach it as an asset to the release.

The changes in this PR were tested on my fork to create https://github.com/joshuacwnewton/spinalcordtoolbox/releases/tag/5.7.5, which indeed has the batch script attached as a release asset, with the correct line changed:

  rem Set git ref. If no git ref is specified when calling `install_sct.bat`, use a default instead.
  if [%1]==[] (
    set git_ref=5.7.5
  ) else (
    set git_ref=%1
  )

Linked issues

Fixes #3763.

@joshuacwnewton joshuacwnewton added the CI category: TravisCI, GitHub Actions, etc. label Jul 25, 2022
@joshuacwnewton joshuacwnewton added this to the 5.7 milestone Jul 25, 2022
Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks fine, so I'm approving this. My questions are really more out of curiosity.

I'm also noticing that ncipollo/release-action@v1 has another output parameter called upload_url (see here), which the GitHub docs say we could directly use with curl to upload assets (example in the sidebar here), but that's probably more trouble to debug than just using an existing action.

.github/workflows/create-release.yml Outdated Show resolved Hide resolved
@mguaypaq mguaypaq merged commit 5eb984d into master Jul 26, 2022
@mguaypaq mguaypaq deleted the jn/3763-append-install_sct-asset-in-release-workflow branch July 26, 2022 17:09
@mguaypaq mguaypaq added install_sct.bat context: and removed install_sct.bat context: labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI category: TravisCI, GitHub Actions, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release workflow to add install_sct.bat as a release asset
2 participants