Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions runners to match current (non-beta) up-to-date versions #3853

Merged
merged 8 commits into from Jul 27, 2022

Conversation

joshuacwnewton
Copy link
Member

Checklist

GitHub

PR contents

Description

This goes a bit above-and-beyond #3852, but I figured I would update everything together.

As mentioned in f8547fb:

NB: We may also want to test ubuntu-22.04 and windows-2022 against both tests and batch-processing, too, just to be prepared for future deprecations.

I wanted to start by testing macos-12 in tests.yml, but we should maybe add additional commits afterwards for these cases, too.

Linked issues

Fixes #3852.

This was a temporary blocker until macos-11 became supported. We can replace it with the usual conditional now that `macos-11` is supported,
NB: We may also want to test `ubuntu-22.04` and `windows-2022` against both `tests` and `batch-processing`, too, just to be prepared for future deprecations.

But, perhaps this should be done gradually as to not overload a single PR?
@joshuacwnewton joshuacwnewton added CI category: TravisCI, GitHub Actions, etc. maintenance labels Jul 26, 2022
@joshuacwnewton joshuacwnewton self-assigned this Jul 26, 2022
Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm noticing that .github/workflows/tests.yml still contains a bunch of references to ubuntu-18.04, should some of them also be updated to ubuntu-20.04? (Some of them have an explicit comment about wanting to use an older kernel, so probably not those.)

@joshuacwnewton
Copy link
Member Author

I'm noticing that .github/workflows/tests.yml still contains a bunch of references to ubuntu-18.04, should some of them also be updated to ubuntu-20.04? (Some of them have an explicit comment about wanting to use an older kernel, so probably not those.)

Ah, sorry! My rationale for d6d58e6 wasn't very clear.

For both create-release.yml and test-batch-processing.yml, I wanted the distributions we test to match the "core" set of distributions we test on PRs in tests.yml. I only bumped 18.04 -> 20.04 for test-batch-processing because it was mismatched compared to the other 2.

My thinking is that we would bump the other 18.04-based runners in tests.yml only after GitHub Actions no longer offers it? But, maybe there's a different approach we could use?

@mguaypaq
Copy link
Member

As noted in the deprecation announcement, we've entered a 24-hour period where macOS 10.15 runners are unavailable (July 27 from midnight UTC to midnight UTC). This is the missing automated check to merge this PR (after which, we won't be blocked by the automated check for other PRs). I don't have admin privileges for this repo, so I can't bypass it, unfortunately. @joshuacwnewton, would you do the honours?

@joshuacwnewton
Copy link
Member Author

joshuacwnewton commented Jul 27, 2022

This is the missing automated check to merge this PR (after which, we won't be blocked by the automated check for other PRs)

I think this might also be because macos-10.15 has been removed from the CI workflow entirely?

image

If I remove this requirement (since it's going to be replaced with macos-11 anyway), this PR should become mergeable without admin privileges. (EDIT: Done!)

@mguaypaq mguaypaq merged commit 1cebd51 into master Jul 27, 2022
@mguaypaq mguaypaq deleted the jn/3852-update-macos-runners branch July 27, 2022 12:21
@mguaypaq
Copy link
Member

And now that the PR is merged, I added macOS 11 as a required check:
image

@mguaypaq mguaypaq added this to the 5.7 milestone Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI category: TravisCI, GitHub Actions, etc. maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"The macOS 10.15 Actions runner image is being deprecated" -- replace with macos-11
2 participants