New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Actions runners to match current (non-beta) up-to-date versions #3853
Conversation
This was a temporary blocker until macos-11 became supported. We can replace it with the usual conditional now that `macos-11` is supported,
NB: We may also want to test `ubuntu-22.04` and `windows-2022` against both `tests` and `batch-processing`, too, just to be prepared for future deprecations. But, perhaps this should be done gradually as to not overload a single PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm noticing that .github/workflows/tests.yml
still contains a bunch of references to ubuntu-18.04
, should some of them also be updated to ubuntu-20.04
? (Some of them have an explicit comment about wanting to use an older kernel, so probably not those.)
Ah, sorry! My rationale for d6d58e6 wasn't very clear. For both My thinking is that we would bump the other 18.04-based runners in |
As noted in the deprecation announcement, we've entered a 24-hour period where macOS 10.15 runners are unavailable (July 27 from midnight UTC to midnight UTC). This is the missing automated check to merge this PR (after which, we won't be blocked by the automated check for other PRs). I don't have admin privileges for this repo, so I can't bypass it, unfortunately. @joshuacwnewton, would you do the honours? |
I think this might also be because If I remove this requirement (since it's going to be replaced with |
Checklist
GitHub
PR contents
Description
This goes a bit above-and-beyond #3852, but I figured I would update everything together.
As mentioned in f8547fb:
I wanted to start by testing
macos-12
intests.yml
, but we should maybe add additional commits afterwards for these cases, too.Linked issues
Fixes #3852.