Call parser.error properly
#3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function never returns with a value; it either exits the program, or raises an exception. There's no need to raise the non-existent return value.
mguaypaq
added
sct_process_segmentation
joshuacwnewton
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
raise parser.error(...)anti-pattern from the codebase.The function
parser.error()fromargparsenever returns with a value; it either exits the program, or raises an exception. There's no need to raise the non-existent return value.All other
raisestatements look like they raise actual exceptions (maybe not always the most appropriate one, but at least an exception). While checking this, I couldn't ignore two cases ofraise Exception(TypeError), so I fixed those as well.