Simplify add_suffix
#3878
Merged
Simplify add_suffix
#3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The strings are already concatenated by `+`, and `os.path.join` with a single string argument just returns it unchanged.
mguaypaq
added
refactoring
joshuacwnewton
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Yes, this makes perfect sense! os.path.join was doing nothing here. :)
Plus, any pathlike components should be contained entirely in stem, with suffix and ext not needing to use platform-specific path separators or anything like that, so regular old string concatenation is fine here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strings are already concatenated by
+, andos.path.joinwith a single string argument just returns it unchanged.