Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Ubuntu 18.04 -> 20.04/22.04 in test suite #3919

Merged
merged 6 commits into from Oct 27, 2022
Merged

Upgrade Ubuntu 18.04 -> 20.04/22.04 in test suite #3919

merged 6 commits into from Oct 27, 2022

Conversation

joshuacwnewton
Copy link
Member

@joshuacwnewton joshuacwnewton commented Oct 14, 2022 •
edited

Description

In our test suite, we have two kinds of jobs:

  1. OSs natively supported by GitHub Actions
  2. OSs that must be run via docker containers.

For this 2nd kind, we use ubuntu-18.04 as the base runner, then run docker on top of that using the container: keyword.

However:

  • The CentOS Stream 8 CI job is having some troubles, and I want to test whether upgrading to ubuntu-20.04 fixes this.
  • Additionally, support for 18.04 will be removed on Dec 1, 2022. And, ArchLinux is already conducting a brownout for ubuntu-18.04: 
    This is a scheduled Ubuntu-18.04 brownout. The Ubuntu-18.04 environment is deprecated and will be removed on December 1st, 2022. For more details, see

Linked issues

Fixes #3918.

@joshuacwnewton joshuacwnewton mentioned this pull request Oct 14, 2022
Closed
@joshuacwnewton
tests.yml: Upgrade Ubuntu 18.04 -> 20.04/22.04
993fcfd 
* Support for 18.04 will be removed on Dec 1, 2022.
* The CentOS Stream 8 CI job is having some troubles, and I want to test whether upgrading to ubuntu 20.04 fixes this.
@joshuacwnewton joshuacwnewton force-pushed the jn/3918-test-fixes-for-failing-stream8-jobs branch from 1859b42 to 993fcfd Compare October 14, 2022 15:10
@joshuacwnewton joshuacwnewton marked this pull request as ready for review October 14, 2022 16:42
@joshuacwnewton joshuacwnewton force-pushed the jn/3918-test-fixes-for-failing-stream8-jobs branch from c554d0d to 0835fbe Compare October 17, 2022 15:02
@joshuacwnewton joshuacwnewton mentioned this pull request Oct 18, 2022
Merged
mguaypaq
mguaypaq approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/tests.yml Show resolved Hide resolved
@mguaypaq mguaypaq merged commit 8905396 into master Oct 27, 2022
@mguaypaq mguaypaq deleted the jn/3918-test-fixes-for-failing-stream8-jobs branch October 27, 2022 16:33
@joshuacwnewton joshuacwnewton added this to the 5.8 milestone Nov 29, 2022
@joshuacwnewton joshuacwnewton added the CI category: TravisCI, GitHub Actions, etc. label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguaypaq mguaypaq mguaypaq approved these changes

Assignees
No one assigned
Labels
CI category: TravisCI, GitHub Actions, etc.
Projects
None yet
Milestone
5.8
Development

Successfully merging this pull request may close these issues.

CentOS Stream 8 CI jobs are being cancelled after some time (with no logs to debug)
2 participants
@joshuacwnewton @mguaypaq