New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring metrics in PAM50 anatomical dimensions in sct_process_segmentation
#3977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the SUM(length)
column, put n/a
instead
TODO: change the output csv file with |
…s including `.` like /home/GRAMES.POLYMTL.CA)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new changes LGTM! But, as a result of the newest changes, we now have test failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm just about ready to approve this? It mostly LGTM! I just had one last question (and one more task for myself).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the tests pass with the new dataset release, this LGTM! I'd say it's ready to merge.
Links to next steps:
Checklist
GitHub
PR contents
Description
This PR adresses #3733 . The concept is to bring metrics generated in
sct_process_segmentation
to the PAM50 anatomical space in order to do slicewise comparison. The metrics need to be computed slicewise and the vertfile needs to be specified. 2 .csv files will be output.-normalize PAM50
insct_process_segmentation
metrics_to_PAM50.py
To run the script:
Linked issues
Fixes #3733. (We should reopen the issue after this PR is merged, as there are other ideas in the issue.)