Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update description of -file_centerline flag to mention -centerline file instead of -centerline manual #4018

Merged
merged 1 commit into from Jan 30, 2023
Merged

Update description of -file_centerline flag to mention -centerline file instead of -centerline manual #4018

merged 1 commit into from Jan 30, 2023

Conversation

jqmcginnis
Copy link
Contributor

@jqmcginnis jqmcginnis commented Jan 30, 2023 •
edited by joshuacwnewton

Checklist

GitHub

PR contents

Description

This PR is about addressing issue #4017 - it applies no functional changes to the code at all, only changes some misleading information in the description of the function and its command line parameters.

Linked issues

Fixes #4017.

joshuacwnewton
joshuacwnewton approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@joshuacwnewton joshuacwnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you for this. ❤️

@joshuacwnewton joshuacwnewton added documentation category: readthedocs, sourceforge, or SCT courses sct_deepseg context: Global entry point for all deep learning segmentation methods labels Jan 30, 2023
@joshuacwnewton joshuacwnewton added this to the 6.0 milestone Jan 30, 2023
@joshuacwnewton joshuacwnewton changed the title change description of sct_deepseg_lesion -file_centerline Update description of -file_centerline flag to mention -centerline file instead of -centerline manual Jan 30, 2023
@joshuacwnewton joshuacwnewton merged commit 9f4d05a into spinalcordtoolbox:master Jan 30, 2023
@joshuacwnewton joshuacwnewton deleted the jqm/4017-sct_deepseg_lesions_description branch January 30, 2023 15:26
@joshuacwnewton joshuacwnewton added sct_deepseg_lesion context: and removed sct_deepseg context: Global entry point for all deep learning segmentation methods labels Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacwnewton joshuacwnewton joshuacwnewton approved these changes

Assignees

@jqmcginnis jqmcginnis

Labels
documentation category: readthedocs, sourceforge, or SCT courses sct_deepseg_lesion context:
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

Argparse description for -file_centerline mentions a non-existent -centerline manual option
2 participants
@jqmcginnis @joshuacwnewton