Catch errors from outdated wxpython versions bundled with FSL, then suggest a solution
#4048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuacwnewton
added
bug
joshuacwnewton
commented
Feb 22, 2023
joshuacwnewton
force-pushed
the
jn/3988-handle-wxpython-error-in-fsleyes-script
branch
from
b1c7101
to
7428cc9
Compare
mguaypaq
approved these changes
Feb 23, 2023
Co-authored-by: Mathieu Guay-Paquet <mathieu.guaypaquet@gmail.com>
Co-authored-by: Mathieu Guay-Paquet <mathieu.guaypaquet@gmail.com>
joshuacwnewton
deleted the
jn/3988-handle-wxpython-error-in-fsleyes-script
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR more gracefully handles an error thrown by FSLeyes when WxPython is out of date (buggy:
4.1.1, fixed:4.2.0).Before:
After:
This out of date WxPython is installed when using the "FSL installation method" for FSLeyes. So, we provide FSL-specific instructions for updating WxPython within the FSL conda environment.
(If FSLeyes is installed via a dedicated conda environment, then an up-to-date WxPython will be installed, and thus will be unaffected by this bug.)
Linked issues
Fixes #3988