Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor get_dimension #4097

Merged
merged 2 commits into from Apr 24, 2023
Merged

Refactor get_dimension #4097

merged 2 commits into from Apr 24, 2023

Conversation

yupbank
Copy link
Contributor

@yupbank yupbank commented Apr 21, 2023 •
edited by mguaypaq

Checklist

GitHub

PR contents

Description

Linked issues

@yupbank yupbank force-pushed the minor-change branch 2 times, most recently from 6cd9897 to 0becc59 Compare April 21, 2023 13:56
mguaypaq
mguaypaq reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, but is there a reason for this refactoring? There's no linked issue and the PR description doesn't give any context.

spinalcordtoolbox/image.py Outdated Show resolved Hide resolved
spinalcordtoolbox/image.py Outdated Show resolved Hide resolved
spinalcordtoolbox/image.py Outdated Show resolved Hide resolved
mguaypaq
mguaypaq approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! I'm still a bit puzzled as to the context for this change, but I'll approve it.

@mguaypaq mguaypaq added refactoring category: improves code structure without affecting user-facing functionality SCT API: image.py context: labels Apr 24, 2023
@mguaypaq mguaypaq added this to the 6.0 milestone Apr 24, 2023
@mguaypaq mguaypaq changed the title refactor the get image dimension code Refactor get_dimension Apr 24, 2023
@mguaypaq mguaypaq merged commit 7a83259 into spinalcordtoolbox:master Apr 24, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguaypaq mguaypaq mguaypaq approved these changes

Assignees
No one assigned
Labels
refactoring category: improves code structure without affecting user-facing functionality SCT API: image.py context:
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yupbank @mguaypaq