Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning filters for upstream pkg_resources warnings #4127

Merged
merged 2 commits into from May 30, 2023

Conversation

joshuacwnewton
Copy link
Member

@joshuacwnewton joshuacwnewton commented May 30, 2023

Description

In #4124, we attempted to address pkg_resources API usage DeprecationWarnings by removing all usage of pkg_resources from SCT. As it turns out, though, SCT wasn't the only source of these warnings.

Instead, the call-specific warnings are from upstream packages. (There are open issues for solving these warnings in their respective packages (matplotlib, google_auth), see: #4123 (comment))

So, the best we can do is filter these warnings while we wait. (This is the option chosen by many projects, see: https://github.com/search?q=ignore%3ADeprecated+call&type=code)

Linked issues

Fixes #4123

These warnings are from upstream packages, so we cannot fix them.

Additionally, there are open issues for solving these warnings in their
respective packages (matplotlib, google_auth).

So, the best we can do is filter these warnings while we wait.
@joshuacwnewton joshuacwnewton added tests context: unit, integration, or functional tests upstream Issue caused by software dependencies CI category: TravisCI, GitHub Actions, etc. labels May 30, 2023
@joshuacwnewton joshuacwnewton added this to the 6.0 milestone May 30, 2023
@joshuacwnewton joshuacwnewton self-assigned this May 30, 2023
Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the sleuthing, and for leaving an explanatory comment next to the new filters.

@joshuacwnewton joshuacwnewton merged commit c0a4fd5 into master May 30, 2023
24 checks passed
@joshuacwnewton joshuacwnewton deleted the jn/4123-add-filters-for-upstream-warnings branch May 30, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI category: TravisCI, GitHub Actions, etc. tests context: unit, integration, or functional tests upstream Issue caused by software dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning in test suite: pkg_resources is deprecated as an API
2 participants