Upgrade SCT's conda environment to Python 3.9 #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we allowed the range `pyqt==5.12-5.14`.
However, for some reason, Python 3.9 wheels don't exist for `5.13.*` or `5.14.*`, and they don't exist for `5.12.{0,1,2}`, but they *do* exist for `5.12.3`. I don't quite understand why this random older patch version of pyqt5 has Python 3.9 wheels?
Nonetheless, it seems like `pyqt==5.12.3` is the safest thing to standardize on for any Python 3.9-based releases.
Relevant links:
- Has 3.9 wheels:
- https://pypi.org/project/PyQt5/5.12.3/#files
- Doesn't have 3.9 wheels:
- https://pypi.org/project/PyQt5/5.12.2/#files
- https://pypi.org/project/PyQt5/5.13.2/#files
- https://pypi.org/project/PyQt5/5.14.2/#files
mguaypaq
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a relatively straightforward PR that updates the SCT conda environment from Python 3.8 to Python 3.9. It contains typical updates the install scripts, and also fixes 1 blocker:
pyqt5only has Python 3.9 wheels for version5.12.3.I'm not sure when we want to merge this, as we have until October 2024 for the Python 3.8 EOL. But, I was thinking that, because we're releasing a new major version (SCT v6.0), and we're switching from system Python to conda installation for Windows (#4027), now might be a good time to bump the Python version, as another way of distinguishing between 5.X releases and 6.X releases.
Linked issues
Fixes #3367.