New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial for sct_compute_compression
in documentation
#4162
Add tutorial for sct_compute_compression
in documentation
#4162
Conversation
….com:spinalcordtoolbox/spinalcordtoolbox into sb/4158-add-tutorial-sct-compute-compression
documentation/source/user_section/tutorials/normalizing-morphometrics-compression.rst
Outdated
Show resolved
Hide resolved
...rce/user_section/tutorials/normalizing-morphometrics-compressions/normalization-pipeline.rst
Outdated
Show resolved
Hide resolved
...rce/user_section/tutorials/normalizing-morphometrics-compressions/normalization-pipeline.rst
Outdated
Show resolved
Hide resolved
.../user_section/tutorials/normalizing-morphometrics-compressions/normalizing-morphometrics.rst
Outdated
Show resolved
Hide resolved
.../user_section/tutorials/normalizing-morphometrics-compressions/normalizing-morphometrics.rst
Outdated
Show resolved
Hide resolved
...ser_section/tutorials/normalizing-morphometrics-compressions/generating-necessary-inputs.rst
Outdated
Show resolved
Hide resolved
.../user_section/tutorials/normalizing-morphometrics-compressions/normalizing-morphometrics.rst
Outdated
Show resolved
Hide resolved
.../user_section/tutorials/normalizing-morphometrics-compressions/normalizing-morphometrics.rst
Outdated
Show resolved
Hide resolved
.../user_section/tutorials/normalizing-morphometrics-compressions/normalizing-morphometrics.rst
Outdated
Show resolved
Hide resolved
.../user_section/tutorials/normalizing-morphometrics-compressions/normalizing-morphometrics.rst
Outdated
Show resolved
Hide resolved
.../user_section/tutorials/normalizing-morphometrics-compressions/normalizing-morphometrics.rst
Outdated
Show resolved
Hide resolved
.../user_section/tutorials/normalizing-morphometrics-compressions/normalizing-morphometrics.rst
Outdated
Show resolved
Hide resolved
.../tutorials/shape-analysis/normalizing-morphometrics-compressions/normalize-morphometrics.rst
Outdated
Show resolved
Hide resolved
.../tutorials/shape-analysis/normalizing-morphometrics-compressions/normalize-morphometrics.rst
Outdated
Show resolved
Hide resolved
.../tutorials/shape-analysis/normalizing-morphometrics-compressions/normalize-morphometrics.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @sandrinebedard! The tutorial is excellent! I left only a few very minor suggestions.
…ify-correctness.rst Co-authored-by: Julien Cohen-Adad <jcohen@polymtl.ca>
…malizing-morphometrics-compressions/normalize-morphometrics.rst Co-authored-by: Jan Valosek <39456460+valosekj@users.noreply.github.com>
…malizing-morphometrics-compressions/before-starting.rst Co-authored-by: Jan Valosek <39456460+valosekj@users.noreply.github.com>
…malizing-morphometrics-compressions/normalize-morphometrics.rst Co-authored-by: Jan Valosek <39456460+valosekj@users.noreply.github.com>
…malizing-morphometrics-compressions/normalize-morphometrics.rst Co-authored-by: Jan Valosek <39456460+valosekj@users.noreply.github.com>
@joshuacwnewton is there a way here: https://spinalcordtoolbox--4162.org.readthedocs.build/user_section/tutorials/shape-analysis.html to only have the |
Yes, of course! When we include a page in the TOC, like this:
It will include links to all top-level headers in the file. And, in this case, the CSA page has multiple top-level headers ( Lines 3 to 10 in 4ab64c6
So, it is just a matter of bumping the lower headers down to the next level by using a symbol other than |
This will make sure the sub-headers don't get included in the TOC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Since the "Shape metrics" section has been reorganized, I realize the structure is a bit strange?
Shape analysis
-- Before starting
-- CSA
-- Other shape metrics
-- Verifying correctness
-- Compression
-- Before starting
-- [...]
There's kind of... two nested "before starting" pages? (It's like the first set of pages are individual pages, while "Compression" is a whole extra sub-tutorial.) Which could get a little confusing...
So, I'm wondering if a structure like this could be better:
Shape analysis
-- 1. Computing CSA, area, and other shape metrics
-- Before starting
-- CSA
-- Other shape metrics
-- Verifying correctness
-- 2. Compression
-- Before starting
-- [...]
That way, "Before starting" applies to each of the 2 different sub-tutorials (1. basic sct_process_segmentation usage 2. using sct_process_segmentation for compression analysis).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same structure that the "Registration" section has -- one "main page" divided into separate self-contained sub-tutorials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I'm wondering if a structure like this could be better:
Shape analysis
-- 1. Computing CSA, area, and other shape metrics
-- Before starting
-- CSA
-- Other shape metrics
-- Verifying correctness
-- 2. Compression
-- Before starting
-- [...]
Makes sense to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I'll make this change, check over any remaining outstanding feedback (i.e. the open comments from Julien at the start of the PR), and then merge this PR. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in da38c92!
I think we're good to merge now. :)
Checklist
GitHub
PR contents
Description
This PR adresses #4158. It adds a tutorial for
sct_compute_compression
It includes:
Linked issues
Resolves #4158
Data
Links are not working yet for the data, so here are the zip files:
data_compression.zip
data_normalizing-morphometrics-compression.zip
TODO