Fix QC for soft segmentations that have light regions close to 1.0 (e.g. 0.999)
#4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This accounts for softseg images with light regions that are close to 1.0, but not exactly 1.0.
mguaypaq
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
This also has the effect of bucketing all the other values into intervals of size 0.1, which makes binary_most_common a more stringent test, so probably a bit more robust.
LGTM, although I still think the long-term solution is for the QC report code to keep track of which images are intended to be segmentations.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #4133, we added a heuristic-based check for segmentations by making sure the values
0.0or1.0are the most common in the image.However, some softsegs have light regions that are not exactly
1.0:So, this PR rounds the segmentation values to 1 decimal place, which ensure that values
>0.95and<0.05must be the most common values in the image, rather than exactly1.0and0.0.Linked issues
Fixes #4178.
Fixes QC issues in #4189.