Fix ValueError by passing a tuple to color= instead of a numpy array
#4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would create a dict of [1,4] numpy arrays representing RGB colors + A (transparency) for each point color. Due to a recent matplotlib update, though, using a numpy array causes an unexpected ValueError. Since a list of size [4] results in the exact same functionality, we can just bypass the error by storing list-based colors instead.
joshuacwnewton
added
bug
tacaswell
reviewed
Sep 18, 2023
Using a list implies that the color could be mutated at some point, but we only ever consume the color after creating the dict of colors.
joshuacwnewton
changed the title
ValueError by passing a list to color= instead of a numpy arrayValueError by passing a tuple to color= instead of a numpy array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we would create a dict of [1,4] numpy arrays representing RGB colors + A (transparency) for each unique bval. Due to a recent matplotlib update, though, using a numpy array causes an unexpected ValueError. (matplotlib/matplotlib#26821)
Since a tuple of size [4] results in the exact same functionality, we can bypass the error by storing tuple-based colors instead.
Linked issues
Fixes #4220.