Avoid dipy versions 1.6.0 + 1.7.0 that contain a method=restore bug
#4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See dipy/dipy#439 (comment) for a description of the problem, as well as a description of the fix that has already been implemented upstream.
joshuacwnewton
added
bug
joshuacwnewton
commented
Sep 28, 2023
mguaypaq
approved these changes
Sep 28, 2023
joshuacwnewton
deleted the
jn/4209-avoid-buggy-dipy-versions-method-restore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sct_dmri_compute_dtifails onsct_example_dataimages when using-method restore:I dug into this on the
dipyside of things, and found that the issue only exists fordipy==1.6.0,1.7.0, and has already been fixed upstream.dipy==1.8.0is releasing soon, so to avoid freezing a buggy version for SCT v6.1, we skip these two versions in our requirements.txt.Note: We have an existing test for this. The reason that our test suite didn't catch this is because
dipychunks the processing, and the test image is smaller than a single chunk, but the bug only occurs when there are >1 chunks. I'm not quite sure how to test for this given our available testing data? But maybe given that this is a one-off issue with an upstream library, we don't necessarily need to test for this.Linked issues
Fixes #4209.