Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid onnxruntime 1.16.0 but allow onnxruntime >=1.16.1 #4256

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

joshuacwnewton
Copy link
Member

Description

Given that SCT v6.1 hasn't been released yet, I quickly checked in on #4225, and found the following comment:

1.16.1 was released with the below fix commit.
1c245e6

If true, then we can remove the <1.16.0 limitation and replace it with !=1.16.0.

Linked issues

Fixes #4225.

@joshuacwnewton joshuacwnewton added bug category: fixes an error in the code upstream Issue caused by software dependencies labels Oct 16, 2023
@joshuacwnewton joshuacwnewton added this to the 6.1 milestone Oct 16, 2023
@joshuacwnewton joshuacwnewton self-assigned this Oct 16, 2023
Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for checking upstream!

@joshuacwnewton joshuacwnewton merged commit 23776c3 into master Oct 16, 2023
24 checks passed
@joshuacwnewton joshuacwnewton deleted the jn/4225-avoid-onnxruntime-1.16.0 branch October 16, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug category: fixes an error in the code upstream Issue caused by software dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream bug: onnxruntime==1.16.0 requires a parameter meant for GPUs (even though SCT uses the CPU version)
2 participants