Update PAM50 template links and fix related test errors #4268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The results changed because of updates to the `PAM50_cord.nii.gz` file, which affects the registration quality for the DMRI and MT coregistration.
This was referenced Oct 24, 2023
mguaypaq
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Thanks for the thorough investigation and the fixes and updates. There's not much to check for the disabled test (I agree with the rationale, and you included a link to it in the comments), and with the updated cached results. I did check that both download links work and point to identical files.
jcohenadad
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Thank you for the investigations @joshuacwnewton ! The changes in results are minor and expected, so I wouldn't worry about this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the PAM50 template links to include new changes to the PAM50 template, including cauda equinea labels (needed for #4250) and updates to the PAM50 cord and levels files. (Full details here.)
These updates, however, caused some failures to existing tests. I previously investigated these in #4254 (comment), and added fixes in #4250 (comment). But, I think it's better to keep all of these related changes outside of the tutorial PR. So, I've cherry-picked the fixes here as well, and will revert the associated commits in #4254.
Linked issues
Fixes #4254.
Partially addresses #4215. (We still need to update the SCT course to account for the spinal levels.)