Remove unused Image.verbose attribute
#4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attribute is never actually read anywhere. Instead, the pattern is that individual methods of `Image` which can be chatty accept a `verbose` parameter.
mguaypaq
added
refactoring
joshuacwnewton
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny tiny PR, but I noticed it once and it bothered me: the attribute
Image.verboseis saved in__init__, but is never actually read anywhere. Instead, the pattern is that individual methods ofImagewhich can be chatty accept averboseparameter.(To be sure that no one at all uses
Image.verbose, I searched all python files for the string.verbose. All instances are either:self.verbosein another class,param.verbosein various scripts,SpinalCordStraightener.verbose,Transform.verbose, orImageCropper.verbose.)