Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address test warnings by pinning pyqt5-sip<12.13.0 and updating setup.cfg ignore entries (pkg_resources) #4355

Merged
merged 13 commits into from Feb 15, 2024
Merged

Address test warnings by pinning pyqt5-sip<12.13.0 and updating setup.cfg ignore entries (pkg_resources) #4355

merged 13 commits into from Feb 15, 2024

Conversation

joshuacwnewton
Copy link
Member

@joshuacwnewton joshuacwnewton commented Feb 1, 2024 •
edited

Description

This is a small PR to revisit the warnings caught by our test suite:

Linked issues

Fixes #4354.

@joshuacwnewton joshuacwnewton added installation category: install_sct or pip/setup.py maintenance labels Feb 1, 2024
@joshuacwnewton joshuacwnewton added this to the 6.2 milestone Feb 1, 2024
@joshuacwnewton joshuacwnewton self-assigned this Feb 1, 2024
@joshuacwnewton joshuacwnewton changed the title Manage test warnings by pinning pyqt5-sip<=12.13 and removing a warning ignore entry Manage test warnings by pinning pyqt5-sip<12.13.0 and removing a warning ignore entry Feb 1, 2024
joshuacwnewton
joshuacwnewton commented Feb 1, 2024
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
@joshuacwnewton joshuacwnewton changed the title Manage test warnings by pinning pyqt5-sip<12.13.0 and removing a warning ignore entry Manage test warnings by pinning pyqt5-sip<12.13.0 and updating pkg_resources ignore entry Feb 1, 2024
@joshuacwnewton joshuacwnewton changed the title Manage test warnings by pinning pyqt5-sip<12.13.0 and updating pkg_resources ignore entry Address test warnings by pinning pyqt5-sip<12.13.0 and updating setup.cfg ignore entries (pkg_resources) Feb 1, 2024
@joshuacwnewton joshuacwnewton marked this pull request as ready for review February 1, 2024 23:48
@mguaypaq mguaypaq self-requested a review February 12, 2024 21:26
@joshuacwnewton
Copy link
Member Author

joshuacwnewton commented Feb 13, 2024 •
edited

Removing this from the 6.2 milestone since it is not critical to review this prior to 6.2.

(If it happens to get reviewed in time, that's a bonus, but I don't think it's urgent!)

@joshuacwnewton joshuacwnewton modified the milestones: 6.2, 6.3 Feb 13, 2024
joshuacwnewton
joshuacwnewton commented Feb 14, 2024
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
mguaypaq
mguaypaq approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this bit of maintenance!

@joshuacwnewton joshuacwnewton merged commit eded0c2 into master Feb 15, 2024
20 checks passed
@joshuacwnewton joshuacwnewton deleted the jn/4345-manage-new-warnings branch February 15, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguaypaq mguaypaq mguaypaq approved these changes

Assignees

@joshuacwnewton joshuacwnewton

Labels
installation category: install_sct or pip/setup.py maintenance
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

Address new test warnings (and double-check the existing ignore list)
2 participants
@joshuacwnewton @mguaypaq