Move most broken link checking to a daily job #4428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a little too flaky to run on every PR, and besides the main thing it's supposed to catch is when an external website changes, so a daily task is sufficient.
This should catch broken links that are specifically touched by a PR, which is usually no links at all, so it shouldn't be very flaky.
joshuacwnewton
approved these changes
Apr 9, 2024
Since it's a daily job, there's no need to rush. Co-authored-by: Joshua Newton <joshuacwnewton@gmail.com>
mguaypaq
added a commit
that referenced
this pull request
Apr 9, 2024
Since `grep` no longer receives filenames, it no longer puts `$FILENAME:` at the start of each line. But `check-url.sh` _does_ expect a semicolon before the url to check. So we need to insert it, rather than changing the colon after `https` into a semicolon. Follow-up for #4428.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4426.
I still kept a limited form of the link checker for PRs. It should only check added/modified lines, so that should catch typos in new/changed links. The daily job should catch websites that stop working.
For the daily run, I picked a scheduled time that's an hour before all the other tests (either 5am or 6am Montreal time, depending on daylight savings), to avoid resource bottlenecks.