Make sct_download_data errors non-fatal during installations of SCT
#4484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mguaypaq
reviewed
May 15, 2024
We'll reuse this logic to check whether the default datasets are installed.
joshuacwnewton
commented
May 17, 2024
joshuacwnewton
commented
May 17, 2024
I also had the wrong default value for `keep`. In `install_named_dataset`, this is False by default.
This preserves the proper logging, as `init_sct` will initialize the logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR follows the reasoning in #4410 (comment). By allowing
sct_download_datafailures, we mitigate crashing the entire SCT installation if a single dependency fails to install (e.g. due to network/disk issues).That said, it is still important for users to know that the installation of dependencies has failed. So, we also add a new check to
sct_check_dependenciesthat checks if the default data dependencies are installed. As a bonus, this means that the list of defaults no longer has to be hardcoded inside of the individual install scripts.Linked issues
Fixes #4410.