Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update url to slicer documentation #4486

Merged
merged 1 commit into from
May 21, 2024
Merged

Update url to slicer documentation #4486

merged 1 commit into from
May 21, 2024

Conversation

mguaypaq
Copy link
Member

The old url has a big banner at the top of the page, claiming that this new url contains the latest version. A quick look confirms that the content is essentially the same.

I noticed this when checking the daily broken url results:
https://github.com/spinalcordtoolbox/spinalcordtoolbox/actions/runs/9050554894/job/24866074154

The old url has a big banner at the top of the page, claiming that this
new url contains the latest version. A quick look confirms that the content
is essentially the same.
@mguaypaq mguaypaq added the documentation category: readthedocs, sourceforge, or SCT courses label May 16, 2024
@mguaypaq mguaypaq added this to the 6.4 milestone May 16, 2024
Copy link
Member

@joshuacwnewton joshuacwnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

It's strange, normally I get notifications for failed workflow runs, but I didn't get one here.

image

image

Ah...

Notifications for scheduled workflows are sent to the user who initially created the workflow. If a different user updates the cron syntax in the workflow file, subsequent notifications will be sent to that user instead. If a scheduled workflow is disabled and then re-enabled, notifications will be sent to the user who re-enabled the workflow rather than the user who last modified the cron syntax.

This is awkward. Is there a way we can modify the cron syntax but make sure to use "Co-authored-by" to ensure we both get notifications?

@mguaypaq
Copy link
Member Author

Ah, so that's why I suddenly started getting these notifications!

I don't think we both need to receive them. If you'd prefer to receive them, I guess the simplest way would be for you to disable and re-enable the workflow. (It wasn't intuitive to me how to do this, but this help page shows where the relevant menu is hidden.)

@mguaypaq mguaypaq merged commit ca6ad45 into master May 21, 2024
20 checks passed
@mguaypaq mguaypaq deleted the mgp/update-slicer-url branch May 21, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation category: readthedocs, sourceforge, or SCT courses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants