Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests broken #2294

Closed
soininen opened this issue Aug 31, 2023 · 1 comment
Closed

Unit tests broken #2294

soininen opened this issue Aug 31, 2023 · 1 comment
Assignees
@soininen
Labels
bug Something isn't working Test
Milestone
v0.8.0

Comments

@soininen
Copy link
Contributor

soininen commented Aug 31, 2023 •
edited
Loading

Unit tests need to get fixed so we can start doing PRs for 0.8-dev.
@soininen soininen added bug Something isn't working Test 0.8-dev labels Aug 31, 2023
@soininen soininen added this to the v0.8.0 milestone Aug 31, 2023
@soininen soininen self-assigned this Aug 31, 2023
soininen added a commit that referenced this issue Aug 31, 2023
@soininen
Fix test_specification_editor_window
5687dcf 
There was a wrong signature in a mock lambda

Re #2294
soininen added a commit to spine-tools/spine-items that referenced this issue Aug 31, 2023
@soininen
Fix wrong method signature in some specification editor windows
7a6c596 
This was probably a leftover from a merge conflict.

Re spine-tools/Spine-Toolbox#2294
This was referenced Sep 1, 2023
Closed
Closed
soininen added a commit that referenced this issue Sep 1, 2023
@soininen
Refactor test_SpineDBEditor* unit tests
2d9715c 
The "mixin" style tests do not play nice with unit testing system.
This replaces the mixins with a common base class that makes the
tests actually work as independent modules.

Re #2294
soininen added a commit that referenced this issue Sep 1, 2023
@soininen
Check if item is valid before trying to extract data from it
ffb0b9c 
MultiDBTreeItem may have no db_map_ids for a short interval between the
corresponding db item being removed from cache and the tree item still being
a member of a tree. During this interval it was possible that the UI thread would
try to access the data() mathod of MultiDBTreeItem which would Traceback.

Re #2289,#2294
soininen added a commit that referenced this issue Sep 1, 2023
@soininen
Use TempIdDict instead of regular dict
fd0e15c 
Resolution of temporary ids to real ids needs to reach the Database editor,
too. This fixes an issue where you couldn't delete an added item if the
addition was committed to the database in the same session.

Re #2294,#2295
soininen added a commit that referenced this issue Sep 1, 2023
@soininen
Fix unit tests (work-in-progress)
aeff6dd 
Refactor/fix test_custom_qtreeview module. The work is half-done with
one test being currently skipped.

Re #2294
soininen added a commit that referenced this issue Sep 4, 2023
@soininen
Enable and fix value list tree test
63e4d4a 
We need to expand the tree view's items so the lists can
prepare for fetching list values.

Re #2294
soininen added a commit that referenced this issue Sep 4, 2023
@soininen
Fix and refactor unit tests
a29a348 
This finishes refactoring and fixing of test_custom_qtreeview module.
We're trying to drop objects/relationships in favor of entities in tests
as well.

Re #2294
soininen added a commit that referenced this issue Sep 5, 2023
@soininen
Fix unit tests
2c7de59 
Re #2294
soininen added a commit to spine-tools/Spine-Database-API that referenced this issue Sep 6, 2023
@soininen
Fix unit tests
2736e13 
Re spine-tools/Spine-Toolbox#2294
soininen added a commit that referenced this issue Sep 6, 2023
@soininen
Temporarily disable unit tests on Ubuntu
e75f845 
Linx tests fail at a segmentation fault. Disabling them is a stopgap
solution to get unit tests working again for the 0.8-dev branch.

Re #2294
@soininen soininen mentioned this issue Sep 6, 2023
Merged
1 task
soininen added a commit to spine-tools/spine-engine that referenced this issue Sep 6, 2023
@soininen
Fix unit tests
8df5438 
Changed unit tests according to changes in spinedb_api, most notably
the tool filter is now gone.

Re spine-tools/Spine-Toolbox#2294
@soininen soininen mentioned this issue Sep 6, 2023
Merged
3 tasks
soininen added a commit to spine-tools/spine-engine that referenced this issue Sep 6, 2023
@soininen
Use 0.8-dev branches of spinedb_api and spine_items in GitHub actions
fdec0b2 
Re spine-tools/Spine-Toolbox#2294
soininen added a commit that referenced this issue Sep 6, 2023
@soininen
Temporarily disable unit tests on Ubuntu
9eed71d 
Linx tests fail at a segmentation fault. Disabling them is a stopgap
solution to get unit tests working again for the 0.8-dev branch.

Re #2294
soininen added a commit that referenced this issue Sep 6, 2023
@soininen
Fix execution tests
aa4d54b 
Tests were broken due to changes in spinedb_api

Re #2294
soininen added a commit to spine-tools/spine-items that referenced this issue Sep 7, 2023
@soininen
Fix selected dimensions setting in Exporter Specification editor
2630a8c 
There were a few issues with the Selected dimension spin box:
- When Entity dimensions was set to 0, highlight dimension decreased to -1.
  We now set highlight dimension to None instead.
- When Entity dimensions decrease, we need to make sure that Selected dimension
  is not greater than Entity dimensions. In such cases we used to decrease
  Selected dimension before we decreased Entity dimensions which silently
  overwrote the the update in Selected dimension as changing Entity dimensions
  creates new mappings. We now update Entity dimensions first, then adjust
  Selected dimension as needed.

Also, fixed Exporter unit tests.

Re spine-tools/Spine-Toolbox#2294
soininen added a commit to spine-tools/spine-items that referenced this issue Sep 7, 2023
@soininen
Fix unit tests
d64c5d0 
Re spine-tools/Spine-Toolbox#2294
soininen added a commit to spine-tools/spine-items that referenced this issue Sep 7, 2023
@soininen
Use 0.8-dev branch in requirements
a52ab5c 
Re spine-tools/Spine-Toolbox#2294
@soininen soininen mentioned this issue Sep 7, 2023
Merged
3 tasks
@soininen
Copy link
Contributor Author

soininen commented Sep 7, 2023

Done.

@soininen soininen closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soininen soininen

Labels
bug Something isn't working Test
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
1 participant
@soininen