Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jupyter-client requirement and improve some kernel manager stuff #101

Merged
merged 7 commits into from
Jun 14, 2023

Conversation

PekkaSavolainen
Copy link
Member

@PekkaSavolainen PekkaSavolainen commented Jun 8, 2023

  • Update requirements to allow latest jupyter-client
  • Add/update some kernel manager related stuff

Re issue spine-tools/Spine-Toolbox#2154
Re issue spine-tools/Spine-Toolbox#1495

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

- Recent updates to KernelExecutionManager and elsewhere have granted us support for the latest jupyter-client

Re spine-tools/Spine-Toolbox#1495
- Let's not force users to upgrade jupyter-client unless it's necessary

Re spine-tools/Spine-Toolbox#1495
# Conflicts resolved:
#	setup.py
@PekkaSavolainen PekkaSavolainen self-assigned this Jun 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Patch coverage: 72.11% and project coverage change: +0.29 🎉

Comparison is base (12174eb) 68.34% compared to head (2310abb) 68.64%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   68.34%   68.64%   +0.29%     
==========================================
  Files          47       47              
  Lines        3794     3878      +84     
  Branches      731      757      +26     
==========================================
+ Hits         2593     2662      +69     
- Misses       1044     1059      +15     
  Partials      157      157              
Impacted Files Coverage Δ
...ne/execution_managers/conda_kernel_spec_manager.py 15.74% <0.00%> (ø)
...ine/execution_managers/kernel_execution_manager.py 63.68% <22.22%> (-3.99%) ⬇️
spine_engine/project_item/connection.py 83.68% <100.00%> (+0.40%) ⬆️
spine_engine/project_item/executable_item_base.py 74.39% <100.00%> (+0.97%) ⬆️
spine_engine/spine_engine.py 78.36% <100.00%> (+0.04%) ⬆️
spine_engine/utils/helpers.py 72.65% <100.00%> (+6.83%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PekkaSavolainen PekkaSavolainen merged commit c414249 into master Jun 14, 2023
8 checks passed
@PekkaSavolainen PekkaSavolainen deleted the upgraded_jupyter_client branch June 14, 2023 15:19
soininen pushed a commit that referenced this pull request Aug 24, 2023
…ff (#101)

- Allow latest jupyter-client
- Implement restart kernel manager
- Don't raise RuntimeError when making a kernel manager fails but return None instead
- Implement 'kill console at end of execution' for KernelExecutionManager

Re spine-tools/Spine-Toolbox#2154
Re spine-tools/Spine-Toolbox#1495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants