Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolve python interpreter when frozen #143

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

PekkaSavolainen
Copy link
Member

@PekkaSavolainen PekkaSavolainen commented Jun 7, 2024

Always use embedded Python as default when frozen and on Windows. We cannot search python from the PATH because %USERPROFILE%/AppData/Local/Microsoft/WindowsApps/ is in PATH by default on all users and this dir contains a python.exe that either opens the Microsoft Store or opens the Python that was downloaded from the Microsoft Store.

Fixes spine-tools/Spine-Toolbox#2823

Checklist before merging

  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

- Always use embedded Python as the default when frozen and on Windows

Re #2823
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.69%. Comparing base (a2d2c42) to head (56321f5).

Files Patch % Lines
spine_engine/utils/helpers.py 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   62.55%   62.69%   +0.13%     
==========================================
  Files          40       40              
  Lines        3848     3849       +1     
  Branches      766      767       +1     
==========================================
+ Hits         2407     2413       +6     
+ Misses       1293     1288       -5     
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PekkaSavolainen PekkaSavolainen self-assigned this Jun 7, 2024
@PekkaSavolainen PekkaSavolainen merged commit d049af2 into master Jun 7, 2024
11 of 12 checks passed
@PekkaSavolainen PekkaSavolainen deleted the toolbox_issue_2823 branch June 7, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Python on bundled app should point to the embedded Python
1 participant