Make it possible to overwrite client id prefix; also enables catching duplicate ids & cids #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, uid can never detect id or cid collisions because it has no idea of the prefix set for cid.
I believe because uid is only called in one place, the prefix should be set at uid. Then uid can be overridden to provide a custom prefix and also to detect collisions. Therefore it will be a truly "unique id".
I discovered this problem when extending the model to use local storage.
For example:
Using Spine.Model.Local
say Local has ids
c-1
fetch()
then will end up assigningcid c-0
to item withid c-1
Then in create...
...create new
id
, will havecid c-1
, which is then set asid
......and then overwrites the old record...
...this is further finalized when saving.