Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection::add() and Collection::remove() methods #441

Merged
merged 1 commit into from Mar 28, 2013

Conversation

adambiggs
Copy link
Member

This pull request adds methods to add/remove records from a Collection without affecting other records in the Collection.

Turns this:

photo = album.photos().create()
photo.updateAttribute 'album_id', null
photo.updateAttribute 'album_id', album.id

Into this:

photo = album.photos().create()
album.photos().remove photo
album.photos().add photo

@aeischeid
Copy link
Member

we gotta update the spine.site to cover all this relation stuff you have been doing!

aeischeid added a commit that referenced this pull request Mar 28, 2013
Collection::add() and Collection::remove() methods
@aeischeid aeischeid merged commit 0c11e58 into spine:master Mar 28, 2013
@adambiggs adambiggs deleted the add-remove-relations branch March 28, 2013 19:34
@adambiggs
Copy link
Member Author

Agreed! More than happy to help write docs, but I'm waiting to see what happens with #433.

Wouldn't want to update spine.site and then have to rewrite the same docs again somewhere else :)

@aeischeid
Copy link
Member

Yeah. repeating work sucks. However, it is probably going to be at least a few weeks before I am even going to consider rewriting the docs app, so if you have time to kill I think most of the work would be relatively portable if we are just adding documentation on the markdown pages of current spine.site. Your call :)

@adambiggs
Copy link
Member Author

Good point, the markdown will be the same either way. I'll write some docs next chance I get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants