add private image support #68
Conversation
|
This PR now has an image available for testing: |
michelleN
changed the title
|
Hi @michelleN, with #69 merged, do we still need this PR? (or is it something completely different?) |
|
@rajatjindal - I'll remove the ns related commit then this PR will only be related to supporting private images |
michelleN
changed the title
| @@ -97,7 +102,7 @@ helm upgrade spin-operator \ | |||
| --namespace spin-operator \ | |||
| --devel \ | |||
| --wait \ | |||
| oci://ghcr.io/spinkube/spin-operator | |||
| charts/spin-operator | |||
There was a problem hiding this comment.
since we have published charts now, should I take out this change pointing to local path here? @vdice
There was a problem hiding this comment.
Good Q... we do have published prerelease charts now but I can also understand just keeping references local until we have a first official (eg v0.1.0) chart release. As an aside, if we use this updated local reference, we can remove --devel (and the TODO note above.)
| @@ -97,7 +102,7 @@ helm upgrade spin-operator \ | |||
| --namespace spin-operator \ | |||
| --devel \ | |||
| --wait \ | |||
| oci://ghcr.io/spinkube/spin-operator | |||
| charts/spin-operator | |||
There was a problem hiding this comment.
Good Q... we do have published prerelease charts now but I can also understand just keeping references local until we have a first official (eg v0.1.0) chart release. As an aside, if we use this updated local reference, we can remove --devel (and the TODO note above.)
| @@ -65,6 +65,11 @@ The spin-operator chart currently includes the following sub-charts: | |||
|
|
|||
| ### Installing the Chart | |||
|
|
|||
| If the spin operator image you are going to install lives in a private repository, please first create a Kubernetes secret called `ghcr-credentials` in the | |||
| `spin-operator-system` namespace before installing the helm chart below. See the [private-images](#private-images) section below for instructions on how to | |||
There was a problem hiding this comment.
Just double-checking that this spin-operator-system namespace is intended. In the helm install cmds below, spin-operator is used.
There was a problem hiding this comment.
good catch. will update.
There was a problem hiding this comment.
Looks like an update here is still needed.
michelleN
force-pushed
the
helm
branch
2 times, most recently
from
93abfee
to
309a1af
Compare
|
thanks @vdice - updated based on your feedback. |
| @@ -65,6 +65,11 @@ The spin-operator chart currently includes the following sub-charts: | |||
|
|
|||
| ### Installing the Chart | |||
|
|
|||
| If the spin operator image you are going to install lives in a private repository, please first create a Kubernetes secret called `ghcr-credentials` in the | |||
| `spin-operator-system` namespace before installing the helm chart below. See the [private-images](#private-images) section below for instructions on how to | |||
There was a problem hiding this comment.
Looks like an update here is still needed.
|
Does the admin workstation also need to be authed to the private repo or does that all go through the cluster for |
|
@lann it all goes through the cluster |
michelleN
force-pushed
the
helm
branch
3 times, most recently
from
553015f
to
b800065
Compare
|
@endocrimes thanks. updated. |
+ update the Chart README + add imagePullSecrets patch to kustomize templates + adding patch auto generated same updates to helm deployment template + add make target for generated container registry secret Signed-off-by: Michelle Dhanani <michelle@fermyon.com>
Co-authored-by: Danielle <dani@builds.terrible.systems>
Co-authored-by: Danielle <dani@builds.terrible.systems>
Signed-off-by: Michelle Dhanani <michelle@fermyon.com>
|
Since image will be public today, I don't think we need to merge the config updates the way it's done here. We should probably add an optional value to the operator deployment chart for registry credentials. The make target might be helpful but I think it'd be more useful in script under |
This PR is a temporary fix for a templating error described in #66 and it also adds support for working with private spin-operator images.