Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix helm lint by defining new template helper #69

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

rajatjindal
Copy link
Contributor

@rajatjindal rajatjindal commented Feb 15, 2024

helmify replaces release name (in this case spin-operator) with {{ .Release.Namespace }} in dnsNames for Certificate object.

This means {{ include "spin-operator.fullname" . }} gets replaced with {{ include "{{ .Release.Namespace }}.fullname" . }}

This is most likely a bug in helmify, but we can workaround it by defining a new template helper with name {{ .Release.Namespace }}.fullname

Copy link

github-actions bot commented Feb 15, 2024

This PR now has an image available for testing:

  ttl.sh/spoopy-operator-pr-:24h

Copy link
Contributor

@michelleN michelleN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajatjindal !

cc/ @vdice - would love your thoughts here.

Signed-off-by: Rajat Jindal <rajatjindal83@gmail.com>
Copy link
Contributor

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still trying to catch up w/ all of the activity while out sick, but liking the creativity here! Assuming we're still in the phase of wanting to use helmify and not yet ready to manually manage the chart, this seems like a good way to get what we need.

@rajatjindal rajatjindal merged commit e96e0cb into main Feb 15, 2024
7 checks passed
@rajatjindal rajatjindal deleted the helm-lint-fix branch February 15, 2024 16:39
This was referenced Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants