Cleanup testing harness and add integration test for executor-class-based-deployment-config #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danielle Lancashire <dani@builds.terrible.systems>
endocrimes
commented
Feb 27, 2024
|
|
||
| mgr, err := ctrl.NewManager(envTest.cfg, manager.Options{ | ||
| Metrics: metricsserver.Options{BindAddress: "0"}, | ||
| Scheme: envTest.scheme, | ||
| Logger: logger, |
There was a problem hiding this comment.
This change means that when an integration test fails, its logs will be printed alongside the failure - this is pretty helpful for debugging, but can get noisy.
If we decide it is too noisy in the future, then we can also tie it to an env var like SPINKUBE_TEST_LOGS=1 to opt-in.
There was a problem hiding this comment.
Does this github comment belong as a comment in the code for future reference?
|
This PR now has an image available for testing: |
endocrimes
force-pushed
the
dani/testings
branch
from
1da73ec
to
f2fd4d3
Compare
calebschoepp
requested changes
Feb 28, 2024
|
|
||
| mgr, err := ctrl.NewManager(envTest.cfg, manager.Options{ | ||
| Metrics: metricsserver.Options{BindAddress: "0"}, | ||
| Scheme: envTest.scheme, | ||
| Logger: logger, |
There was a problem hiding this comment.
Does this github comment belong as a comment in the code for future reference?
michelleN
approved these changes
Feb 29, 2024
Signed-off-by: Danielle Lancashire <dani@builds.terrible.systems>
endocrimes
force-pushed
the
dani/testings
branch
from
f2fd4d3
to
f7eeca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.