runtimeconfig: ensure secrets are owned by the spinapp #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that secrets are deleted when the app is. We still don't have a way to automatically delete previous versions of the secret, but that's a less important problem than ensuring they go away when the app does. Signed-off-by: Danielle Lancashire <dani@builds.terrible.systems>
endocrimes
requested review from
calebschoepp,
bacongobbler and
michelleN
as code owners
|
There's no accompanying test change here because the garbage collector doesn't run in the |
calebschoepp
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that secrets are deleted when the app is.
We still don't have a way to automatically delete previous versions of the secret, but that's a less important problem than ensuring they go away when the app does.
closes #151