ref(chart): remove kwasm-operator sub-chart #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdice
requested review from
calebschoepp,
endocrimes,
bacongobbler and
michelleN
as code owners
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
vdice
force-pushed
the
ref/rm-kwasm-operator
branch
from
d24b019
to
c0d11ae
Compare
endocrimes
approved these changes
Mar 9, 2024
michelleN
approved these changes
Mar 9, 2024
| @@ -12,6 +12,8 @@ Prior to installing the chart, you'll need to ensure the following: | |||
|
|
|||
| - [Cert Manager](https://github.com/cert-manager/cert-manager) to automatically provision and manage TLS certificates (used by spin-operator's admission webhook system). Cert Manager must be running and the corresponding CRDs must be present on the cluster before installing the spin-operator chart. | |||
|
|
|||
| - [Kwasm Operator](https://github.com/kwasm/kwasm-operator) to install WebAssembly support on Kubernetes nodes. See the [project README.md](https://github.com/KWasm/kwasm-operator/blob/main/README.md) for installation and configuration steps, including annotating nodes to run Spin/wasm workloads. | |||
There was a problem hiding this comment.
We should also specify that the user needs the containerd shim on the node. One way to do that is to install the kwasm operator. Otherwise they could do it manually or use a cluster image that already has it installed. Not blocking. Can do this as a follow up.
endocrimes
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108
Tracking docs updates in spinkube/documentation#79