Executor: Make runtimeClass configurable #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR now has an image available for testing: |
Move the definition of the underlying `runtimeClass` to the executor config. This allows an operator to specify a runtimeClass name that makes sense for their cluster, and allows for multiple runtimeClasses for trying out different node pool versions in a live cluster. Also move deployment creation to the CRD to remove cyclotron-specific handling. Signed-off-by: Danielle Lancashire <dani@builds.terrible.systems>
endocrimes
force-pushed
the
dani/configurable-shim
branch
from
beb9f13
to
796c0a8
Compare
calebschoepp
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the definition of the underlying
runtimeClassto the executor config. This allows an operator to specify a runtimeClass name that makes sense for their cluster, and allows for multiple runtimeClasses for trying out different node pool versions in a live cluster.Also move deployment creation to the CRD to remove cyclotron-specific handling.