Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark replicas as not required #93

Merged
merged 1 commit into from
Feb 22, 2024
Merged

mark replicas as not required #93

merged 1 commit into from
Feb 22, 2024

Conversation

bacongobbler
Copy link
Contributor

closes #18

Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
Copy link

github-actions bot commented Feb 21, 2024

This PR now has an image available for testing:

  ttl.sh/spoopy-operator-pr-:24h

@bacongobbler
Copy link
Contributor Author

bacongobbler commented Feb 21, 2024

Using @ThorstenHans's steps in #18 (comment), things seem to be working now:

><> k3d cluster create wasm-cluster --image ghcr.io/deislabs/containerd-wasm-shims/examples/k3d:v0.11.0 -p "8081:80@loadbalancer" --agents 2
><> kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.14.2/cert-manager.yaml
><> make install run

In another terminal:

><> k apply -f config/samples/hpa.yaml
spinapp.core.spinoperator.dev/hpa-spinapp created
horizontalpodautoscaler.autoscaling/spinapp-autoscaler created

@calebschoepp can you confirm?

@bacongobbler bacongobbler merged commit c02408e into main Feb 22, 2024
6 of 7 checks passed
@bacongobbler bacongobbler deleted the fix-18 branch February 22, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpinApp deployment fails due to missing replicas when enableAutoscaling: true
3 participants